GH-418 Keep default as true for testing_allow_voting

AntelopeIO · Jul 26, 2024 · ee76f64 · ee76f64
1 parent 0c5f170
commit ee76f64
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/libraries/chain/controller.cpp b/libraries/chain/controller.cpp
@@ -960,7 +960,7 @@ struct controller_impl {
    named_thread_pool<chain>        thread_pool;
    deep_mind_handler*              deep_mind_logger = nullptr;
    bool                            okay_to_print_integrity_hash_on_stop = false;
-   bool                            testing_allow_voting = false; // used in unit tests to create long forks or simulate not getting votes
+   bool                            testing_allow_voting = true; // used in unit tests to create long forks or simulate not getting votes
    async_t                         async_voting = async_t::yes;  // by default we post `create_and_send_vote_msg()` calls, used in tester
    async_t                         async_aggregation = async_t::yes; // by default we process incoming votes asynchronously
    my_finalizers_t                 my_finalizers;

diff --git a/libraries/testing/tester.cpp b/libraries/testing/tester.cpp
@@ -337,7 +337,6 @@ namespace eosio::testing {
 
       control.reset( new controller(cfg, std::move(pfs), *expected_chain_id) );
       control->add_indices();
-      control->testing_allow_voting(true);
       if (lambda) lambda();
       chain_transactions.clear();
       [[maybe_unused]] auto accepted_block_connection = control->accepted_block().connect([this]( block_signal_params t ){