Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log entry for legacy producer schedule broken in rc1 #567

Closed
heifner opened this issue Aug 16, 2024 · 0 comments · Fixed by #580 or #588
Closed

log entry for legacy producer schedule broken in rc1 #567

heifner opened this issue Aug 16, 2024 · 0 comments · Fixed by #580 or #588
Assignees
@heifner
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.0.0-rc2

Comments

@heifner
Copy link
Member

heifner commented Aug 16, 2024

It doesn't print the actual schedule.

Aug 16 02:34:39 jungle4-snap143d nodeos[1442895]: info  2024-08-16T02:34:39.434 nodeos    controller.cpp:3193           operator()           ] promoting proposed schedule (set in block 10) to pending; current block: 11 lib: 10 schedule:

Looks like we are logging the value before setting it.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Aug 16, 2024
@arhag arhag added bug The product is not working as was intended. 👍 lgtm and removed triage labels Aug 16, 2024
@arhag arhag added this to the Spring v1.0.0-rc2 milestone Aug 16, 2024
@heifner heifner self-assigned this Aug 19, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Aug 19, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Aug 19, 2024
heifner added a commit that referenced this issue Aug 19, 2024
@heifner
GH-567 Log new proposed schedule after updating variable
648ea46
@heifner heifner mentioned this issue Aug 19, 2024
Merged
@heifner heifner linked a pull request Aug 19, 2024 that will close this issue
[1.0] Fix logging of legacy proposer schedule #580
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Aug 19, 2024
heifner added a commit that referenced this issue Aug 19, 2024
@heifner
Merge pull request #580 from AntelopeIO/GH-567-log-schedule
611ddf9 
[1.0] Fix logging of legacy proposer schedule
heifner added a commit that referenced this issue Aug 19, 2024
@heifner
Merge remote-tracking branch 'spring/release/1.0' into GH-567-log-sch…
e53107c 
…edule-main
@heifner heifner mentioned this issue Aug 19, 2024
Merged
heifner added a commit that referenced this issue Aug 19, 2024
@heifner
Merge pull request #588 from AntelopeIO/GH-567-log-schedule-main
ba241fb 
[1.0 -> main] Fix logging of legacy proposer schedule
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Spring v1.0.0-rc2
3 participants
@heifner @arhag @enf-ci-bot