Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pause-at-block option #570

Closed
heifner opened this issue Aug 17, 2024 · 1 comment · Fixed by #1057
Closed

Add pause-at-block option #570

heifner opened this issue Aug 17, 2024 · 1 comment · Fixed by #1057
Assignees
Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented Aug 17, 2024

Currently one use-case (possibly the largest use-case) of terminate-at-block is to provide the ability to stop a node at a given block height; remove any configured peers, disable incoming peers, and restart the node so that it can be queried at the specified block.

In Spring, we process blocks into the fork database immediately. This means that on shutdown there can be many un-applied blocks in the fork database that would normally be applied on startup. For Spring 1.0.0, we have preserved the functionality (when configured with no configured peers (p2p-peer-address)), to not apply blocks on startup so that if the node was previously stopped with terminate-at-block chain head remains at that block on startup. See #565.

Add a new feature, pause-at-block that would allow a node operator to stop processing of blocks at a specified block height without shutting down. This feature could be used by itself to pause a node at a specified block or with terminate-at-block followed by pause-at-block to restart a node at a specific block without the node possibly processing any additional received blocks from the fork database or from the network.

A new endpoint will be needed as a way to unpause, optionally with a new block pause height. Or we could just require a restart of the node after a pause.

@bhazzard
Copy link

This may make sense as an http endpoint instead of command line.

@bhazzard bhazzard added 👍 lgtm and removed triage labels Sep 20, 2024
@bhazzard bhazzard added this to the Spring v2.0.0 Cusp milestone Sep 20, 2024
@heifner heifner self-assigned this Dec 3, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Dec 3, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Dec 3, 2024
heifner added a commit that referenced this issue Dec 3, 2024
heifner added a commit that referenced this issue Dec 6, 2024
heifner added a commit that referenced this issue Dec 6, 2024
heifner added a commit that referenced this issue Dec 6, 2024
heifner added a commit that referenced this issue Dec 9, 2024
Refactor for pause_at_block functionality
@heifner heifner linked a pull request Dec 12, 2024 that will close this issue
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Dec 12, 2024
heifner added a commit that referenced this issue Jan 2, 2025
heifner added a commit that referenced this issue Jan 22, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants