Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow node with finalizer keys (but no producers) to have no vote-threads #58

Closed
arhag opened this issue Apr 22, 2024 · 0 comments · Fixed by #86
Closed

Allow node with finalizer keys (but no producers) to have no vote-threads #58

arhag opened this issue Apr 22, 2024 · 0 comments · Fixed by #86
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Savanna: Cusp

Comments

@arhag
Copy link
Member

arhag commented Apr 22, 2024

In this case, the node would not validate received votes. However, the votes created by the finalizer would still be propagated to its peers. We can go either way on whether the vote created by the finalizer is integrated in the pending_qc or not in the case when vote-threads is 0.
@arhag arhag added this to the Savanna: Cusp milestone Apr 22, 2024
@heifner heifner self-assigned this Apr 29, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Apr 29, 2024
heifner added a commit that referenced this issue Apr 29, 2024
@heifner
GH-58 Move create_and_send_vote off the main thread.
d916240
heifner added a commit that referenced this issue Apr 29, 2024
@heifner
GH-58 Add test for finalizer with vote-threads=0
3315cd9
@heifner heifner mentioned this issue Apr 29, 2024
Merged
@heifner heifner linked a pull request Apr 29, 2024 that will close this issue
IF: Move create and send vote off the main thread #86
Merged
heifner added a commit that referenced this issue Apr 30, 2024
@heifner
GH-58 Fix access of votes without mutex
c9dacee
heifner added a commit that referenced this issue Apr 30, 2024
@heifner
GH-58 Wait on votes for pushed blocks
de8d76d
heifner added a commit that referenced this issue Apr 30, 2024
@heifner
GH-58 Rename main_thread_t to use_thread_pool_t
108b105
heifner added a commit that referenced this issue May 1, 2024
@heifner
Merge pull request #86 from AntelopeIO/GH-58-finalizer
8a5716c 
IF: Move create and send vote off the main thread
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
None yet
Milestone
Savanna: Cusp
Development

Successfully merging a pull request may close this issue.

IF: Move create and send vote off the main thread AntelopeIO/spring
2 participants
@heifner @arhag