Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.0 -> main] Fix deferred trx processing #1153

Merged
merged 8 commits into from
Feb 10, 2025
Merged

Conversation

heifner
Copy link
Member

@heifner heifner commented Feb 10, 2025

Currently with #1027 a long running trx is interrupted when the oc compile completes. This causes an issue with deferred trx processing in old blocks where deferred trxs exist. Disable interrupt of transaction when oc compile completes for implicit transactions. Implicit transactions include deferred onerror and onblock. Not interrupting onblock seems like an ok thing here as onblock is part of the main system contract.

Also stop() timer on oc interrupt so start() is always called on a stopped timer.
Also call checktime() after setup of cleanup in eos-vm-oc so that set_expiration_callback(nullptr, nullptr); is called on checktime exception.

chicken-dance mismatch still on this branch which is being tracked by #1152

Merges release/1.1 into main including #1150

Resolves #1145

@heifner heifner added OCI Work exclusive to OCI team bug The product is not working as was intended. labels Feb 10, 2025
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: Internal
summary: Fix deferred trx process to support replay-ability.
Note:end

@heifner heifner merged commit 128328b into main Feb 10, 2025
36 checks passed
@heifner heifner deleted the GH-1145-replay-errors-main branch February 10, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The product is not working as was intended. OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring 1.1 Misc Errors During Replay
4 participants