Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fork database logging #163

Merged
merged 3 commits into from
May 19, 2024
Merged

Improve fork database logging #163

merged 3 commits into from
May 19, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented May 18, 2024

  • Change a warn level log to info since it does not necessarily indicate any issue.
  • Add block ids to fork database log output.
  • Add additional fork database log output at shutdown.

@heifner heifner requested review from linh2931 and spoonincode May 18, 2024 15:12
@heifner heifner added the OCI Work exclusive to OCI team label May 18, 2024
@heifner heifner merged commit f818239 into main May 19, 2024
36 checks passed
@heifner heifner deleted the GH-155-fork-warn branch May 19, 2024 02:19
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: LOGGING
summary: Improve fork database logging, additional data added at shutdown.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoonincode spoonincode spoonincode approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heifner @ericpassmore @spoonincode @linh2931