Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0-beta2 -> main] DeepMind: Add ID to ACCEPT_BLOCK_V2 #277

Merged
merged 5 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions libraries/chain/controller.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3284,19 +3284,20 @@ struct controller_impl {
}

if (auto* dm_logger = get_deep_mind_logger(false)) {
auto fd = head_finality_data();
apply<void>(chain_head,
[&](const block_state_legacy_ptr& head) {
if (head->block->contains_header_extension(instant_finality_extension::extension_id())) {
auto fd = head_finality_data(); // for transition blocks
assert(fd);
dm_logger->on_accepted_block_v2(fork_db_root_block_num(), head->block, *fd);
dm_logger->on_accepted_block_v2(head->id(), fork_db_root_block_num(), head->block, *fd);
} else {
dm_logger->on_accepted_block(head);
}
},
[&](const block_state_ptr& head) {
auto fd = head_finality_data();
assert(fd);
dm_logger->on_accepted_block_v2(fork_db_root_block_num(), head->block, *fd);
dm_logger->on_accepted_block_v2(head->id(), fork_db_root_block_num(), head->block, *fd);
});
}

Expand Down
6 changes: 4 additions & 2 deletions libraries/chain/deep_mind.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,14 @@ namespace eosio::chain {
);
}

void deep_mind_handler::on_accepted_block_v2(block_num_type lib, const signed_block_ptr& b, const finality_data_t& fd)
void deep_mind_handler::on_accepted_block_v2(const block_id_type& id, block_num_type lib, const signed_block_ptr& b,
const finality_data_t& fd)
{
auto packed_blk = fc::raw::pack(*b);
auto finality_data = fc::raw::pack(fd);

fc_dlog(_logger, "ACCEPTED_BLOCK_V2 ${num} ${lib} ${blk} ${fd}",
fc_dlog(_logger, "ACCEPTED_BLOCK_V2 ${id} ${num} ${lib} ${blk} ${fd}",
("id", id)
("num", b->block_num())
("lib", lib)
("blk", fc::to_hex(packed_blk))
Expand Down
2 changes: 1 addition & 1 deletion libraries/chain/include/eosio/chain/deep_mind.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class deep_mind_handler
void on_startup(chainbase::database& db, uint32_t head_block_num);
void on_start_block(uint32_t block_num);
void on_accepted_block(const std::shared_ptr<block_state_legacy>& bsp);
void on_accepted_block_v2(block_num_type lib, const signed_block_ptr& b, const finality_data_t& fd);
void on_accepted_block_v2(const block_id_type& id, block_num_type lib, const signed_block_ptr& b, const finality_data_t& fd);
void on_switch_forks(const block_id_type& old_head, const block_id_type& new_head);
void on_onerror(const signed_transaction& etrx);
void on_onblock(const signed_transaction& trx);
Expand Down
68 changes: 34 additions & 34 deletions unittests/deep-mind/deep-mind.log

Large diffs are not rendered by default.

Loading