[1.0-beta4] Log when block has no QCs #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
approved these changes
Jul 30, 2024
|
Note:start |
greg7mdp
approved these changes
Jul 30, 2024
linh2931
reviewed
Jul 30, 2024
libraries/chain/controller.cpp
Outdated
| @@ -3968,6 +3968,10 @@ struct controller_impl { | |||
| auto qc_ext = bsp_in->block->extract_extension<quorum_certificate_extension>(); | |||
| const qc_t& received_qc = qc_ext.qc; | |||
|
|
|||
| dlog("received block: #${bn} ${t} ${prod} ${id}, qc claim: ${qc}, previous: ${p}", | |||
There was a problem hiding this comment.
You can also log after line 3965 if the block does not contain a QC.
linh2931
approved these changes
Jul 30, 2024
greg7mdp
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful to distinguish between only missing one vote or no votes making into a block.
Add log of all recevied blocks with qc claim, previous, and timestamp.