[1.0 -> main] Add max_reversible_blocks_allowed(), use in net_plugin to limit sync-fetch-span #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et_plugin for limiting sync_fetch_span instead of calculating the value in net_plugin
… legacy fork db
[1.0] Add max_reversible_blocks_allowed(), use in net_plugin to limit sync-fetch-span
…ersible-sync-main
greg7mdp
approved these changes
Aug 21, 2024
arhag
approved these changes
Aug 21, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
net_plugincalculating how many reversible blocks are allowed to limitsync-fetch-span, call a method oncontroller. Now logic about which fork database to check is encapsulated to the controller.Merges
release/1.0intomainincluding #609Resolves #608