Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scheduled snapshot requests coming too late in snapshot_in_svnn_transition_test #64

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix scheduled snapshot requests coming too late in snapshot_in_svnn_transition_test #64

merged 1 commit into from
Apr 23, 2024

Conversation

linh2931
Copy link
Member

In race conditions, scheduled snapshot requests can be processed too late, which results in no snapshots taken. Changed to send snapshot requests directly.

Resolved #62.

@linh2931 linh2931 requested review from heifner and greg7mdp April 23, 2024 19:21
@linh2931 linh2931 linked an issue Apr 23, 2024 that may be closed by this pull request
IF: Test Failure: snapshot_in_svnn_transition_test #62
Closed
@linh2931 linh2931 changed the title Fix scheduled snapshot requests coming too late in nodeos_snapshot_diff_test Fix scheduled snapshot requests coming too late in snapshot_in_svnn_transition_test Apr 23, 2024
@linh2931 linh2931 merged commit 3c4b0e0 into savanna Apr 23, 2024
36 checks passed
@linh2931 linh2931 deleted the fix_snapshot_in_svnn_transition_test branch April 23, 2024 21:14
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Improve snapshot scheduling to avoid race conditions, and fixes issues where no snapshot was taken during transition to Savanna.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: Test Failure: snapshot_in_svnn_transition_test
4 participants
@linh2931 @ericpassmore @greg7mdp @heifner