-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF: Use string for variant format of fc::dynamic_bitset #67
Conversation
why is
|
It is not the same number of finalizers in the examples. |
The examples illustrating the changes by this PR should use the same data for clarity I think. |
Updated the PR description to use the same example. |
Implementation has significantly changed.
Note:start |
Original format in the recorded IBC demo:
Format before this PR:
Format in this PR:
A character in the string is '1' if the corresponding bit is set, and '0' if it is not. Character position i in the string corresponds to bit position b.size() - 1 - i.
Also rename some reflected types so their JSON name does not have a
_
prefix.