Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Harden ordered_diff #698

Merged
merged 10 commits into from
Sep 5, 2024
Merged

[1.0] Harden ordered_diff #698

merged 10 commits into from
Sep 5, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 4, 2024

ordered_diff is used to process the finalizer and proposer policy diffs from block header extension finality_extension. Since the finality_extension, is provided to a node to validate, validate the diff during apply_diff.

Related to #691

@heifner heifner requested review from greg7mdp and arhag September 4, 2024 16:52
@heifner heifner added the OCI Work exclusive to OCI team label Sep 4, 2024
@heifner heifner added this to the Spring v1.0.0 milestone Sep 4, 2024
@heifner heifner mentioned this pull request Sep 4, 2024
Closed
@arhag arhag added the validation-protocol Change to the blockchain validation protocol. Impact full validation clients, not light clients. label Sep 4, 2024
arhag
arhag requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@arhag arhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also clean up static_asserts that check the max representable value of SizeType is greater than or equal to config::max_finalizers - 1 or config::max_proposers - 1 .

@arhag arhag added the bug The product is not working as was intended. label Sep 4, 2024
@heifner
Revert invalid change to test
6b55977
@heifner
Add additional test cases
20e5794
@heifner
Remove unneeded and undesired FC_ASSERT of MAX_NUM_ARRAY_ELEMENTS.
291b82a 
Add size_type trait to template.
Add FC_ASSERT outside of loop for source and target size range.
Add back in approprate debug asserts and add some new ones.
Replace invalid comment with correct one.
@heifner
Update static_assert to use ordered_diff size_type and add comment
bc1272f
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Additional checks to harden the processing of the finalizer and proposer policy diffs from block header. extension.
Note:end

Base automatically changed from legacy_qc_ext_checks to release/1.0 September 5, 2024 02:35
@arhag arhag merged commit 2e6a875 into release/1.0 Sep 5, 2024
36 checks passed
@arhag arhag deleted the legacy_qc_ext_checks-harden-checks branch September 5, 2024 02:37
@heifner heifner mentioned this pull request Sep 5, 2024
Merged
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: Internal
summary: Additional checks to harden the processing of the finalizer and proposer policy diffs from block header extension.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@arhag arhag arhag approved these changes

Assignees
No one assigned
Labels
bug The product is not working as was intended. OCI Work exclusive to OCI team validation-protocol Change to the blockchain validation protocol. Impact full validation clients, not light clients.
Projects
None yet
Milestone
Spring v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@heifner @ericpassmore @greg7mdp @arhag