Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0 -> main] Verify finality and QC extensions in Legacy and Transition blocks #702

Merged
merged 24 commits into from
Sep 5, 2024
Merged

[1.0 -> main] Verify finality and QC extensions in Legacy and Transition blocks #702

merged 24 commits into from
Sep 5, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Sep 5, 2024

Forwards #697

Currently verify_qc_claim is only called on Savanna blocks. On Legacy and Transitions blocks, we need to verify finality and QC extensions too.

Resolves #691

linh2931 and others added 24 commits September 4, 2024 12:38
@linh2931
Verify finality and QC extensions in Legacy and Transition blocks
de89f2e
@linh2931
Improve EOS_ASSERT messages
f8157c5
@linh2931
Rename header_ext with finality_ext
aa3aaa5
@linh2931
Use invalid_qc_claim instead of block_validate_exception
ba4d31b
@linh2931
Refactor verify_legacy_block_exts into 3 functions
3d737ca
@linh2931
Add detailed comments and add an EOS_ASSERT for b->is_proper_svnn_blo…
91163d4 
…ck in savanna mode
@linh2931
Simplify prev_finality_ext checks
ba8d755
@linh2931
Remove verify_legacy_and_transition_block_exts_common()
88629d8
@linh2931
Rename savanna_mode with is_proper_savanna_block
4adb976
@linh2931
add more f_ext.new_finalizer_policy_diff check
effc869
@linh2931
Rename verify_qc_claim to verify_proper_block_exts
463d649
@linh2931
Add assert(is_proper_savanna_block == b->is_proper_svnn_block())
2974c04
@linh2931
Make error message more specific about Non Genesis Transition block
e44c48d
@linh2931
more comments
b59612e
@linh2931
Various changes to comments and exception type
35d734d
@linh2931
Use EOS_RETHROW_EXCEPTIONS instead of EOS_THROW
5f503a1
@linh2931
Fix a typo in comment
68eea97
@linh2931
One more invalid_qc_claim which should be block_validate_exception
9a5e133
@linh2931
Rename is_proper_savanna_block to prev_is_of_type_block_state
d4e9960
@linh2931
Revert block_validate_exception to invalid_qc_claim for QC extension …
36e1988 
…to be consistent verify_proper_block_exts
@linh2931
Remove duplicate b->is_proper_svnn_block false check
43bab67
@linh2931
Revert renaming is_proper_savanna_block
31f1d5a
@linh2931
Merge pull request #697 from AntelopeIO/legacy_qc_ext_checks
c2b90f1 
[1.0] Verify finality and QC extensions in Legacy and Transition blocks
@linh2931
Merge remote-tracking branch 'origin/release/1.0' into merge_legacy_q…
596284b 
…c_ext_checks
@linh2931 linh2931 merged commit 07da271 into main Sep 5, 2024
36 checks passed
@linh2931 linh2931 deleted the merge_legacy_qc_ext_checks branch September 5, 2024 03:21
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: Internal
summary: Refactor code to verify finality and QC extensions on Legacy and Transitions blocks, in addition to Savanna blocks.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

@arhag arhag arhag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@linh2931 @ericpassmore @greg7mdp @heifner @arhag