Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.1 -> main] Flush deep-mind logger after each message #739

Merged
merged 3 commits into from
Sep 10, 2024
Merged

[1.0.1 -> main] Flush deep-mind logger after each message #739

merged 3 commits into from
Sep 10, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 10, 2024

fflush each deep-mind log message.

Merges release/1.0 into main including #733

Attempt to resolve #724, reported from issue's creator that this fixes the issue they were seeing.

@heifner heifner added the OCI Work exclusive to OCI team label Sep 10, 2024
@ericpassmore ericpassmore added the enhancement New feature or request label Sep 10, 2024
@ericpassmore
Copy link
Contributor

ericpassmore commented Sep 10, 2024 •
edited
Loading

Note:start
category: Logging
component: DeepMind
summary: Flush DeepMind Logger after each message.
Note:end

@heifner heifner merged commit 849a6bf into main Sep 10, 2024
36 checks passed
@heifner heifner deleted the GH-724-dmlog-flush-main branch September 10, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@spoonincode spoonincode spoonincode approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When starting firehose from a snapshot on kylin, nodeos terminates with DMLOG FPRINTF_FAILURE_TERMINATED
4 participants
@heifner @ericpassmore @greg7mdp @spoonincode