Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.1 -> main] Should never move from a signed_block in a shared_ptr #755

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 11, 2024

Should never move a signed_block that could still be used. The point of shared_ptr is shared data, you don't know if being used by something else unless you just created it. For example if still in the forkdb. Would have preferred to delete the move constructor and move operator= but unfortunately those are needed for our unused http push_block.

Merges release/1.0 into main including #738

Resolves #737

… still might be in use. For example if still in the forkdb. Would have preferred to `delete` the move constructor/operator= but unfortunately those are needed for our unused http push_block.
[1.0.1] Should never move from a signed_block in a shared_ptr
@heifner heifner added the OCI Work exclusive to OCI team label Sep 11, 2024
@heifner heifner linked an issue Sep 11, 2024 that may be closed by this pull request
Base automatically changed from merge_force_all_checks_tests to main September 12, 2024 01:04
@heifner heifner merged commit 6de9662 into main Sep 12, 2024
36 checks passed
@heifner heifner deleted the GH-737-move-block-main branch September 12, 2024 01:08
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: Plugins/Cleos/Utils
summary: Do not move a signed block that may be used later.
Note:end

@ericpassmore ericpassmore added the test-instability tag issues for flaky tests, high priority to address label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team test-instability tag issues for flaky tests, high priority to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: asan block_unit_test_eos-vm-oc
4 participants