[1.0.1 -> main] Should never move from a signed_block in a shared_ptr #755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should never move a
signed_block
that could still be used. The point ofshared_ptr
is shared data, you don't know if being used by something else unless you just created it. For example if still in the forkdb. Would have preferred todelete
the move constructor and move operator= but unfortunately those are needed for our unused httppush_block
.Merges
release/1.0
intomain
including #738Resolves #737