Increment finalizer policy generation on each block that proposes a new finalizer policy; also log when finalizer policy changes #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Apr 29, 2024
linh2931
reviewed
Apr 29, 2024
| // | ||
| // These extensions either result from the execution of the previous block (in case this node | ||
| // was the block producer) or were received from the network in a `signed_block`. | ||
| // ------------------------------------------------------------------------------------------------- |
| // Add this new proposal to the `finalizer_policies` multimap which tracks the in-flight proposals, | ||
| // increment the generation number, and log that proposal (debug level). | ||
| // ------------------------------------------------------------------------------------------------ | ||
| dlog("New finalizer policy proposed in block ${id}: ${pol}", |
There was a problem hiding this comment.
Should we log block number instead?
There was a problem hiding this comment.
The issue specifies that ids should be logged, which makes sense as these blocks are not final, so we may have the same block number in different forks.
linh2931
approved these changes
Apr 29, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #79.
Example of log:
Change of active policy
proposal