[1.0.3 -> main] Fix flaky nodeos_snapshot_diff_test due to a race condition #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1.0.3] Fix issue with block report log time including the time for `maybe_switch_forks`
[1.0.3] Fix flaky nodeos_snapshot_diff_test due to a race condition
greg7mdp
approved these changes
Oct 3, 2024
ericpassmore
approved these changes
Oct 4, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwards #875.
Recently,
nodeos_snapshot_diff_testfails in almost every CICD run.This is due to a race condition that at the startup of head mode node, net thread and http thread can start to work in different order. If http thread processes
schedule_snapshotrequest after net thread starts to sync with the irreversible mode node, schedule_snapshot request will miss the scheduled block number. If it is before net thread starts to sync with the irreversible mode node,schedule_snapshotrequest will catch the scheduled block number and the snapshot is taken.This PR changes to start up the head mode node while the irreversible mode node is down so that net thread will not sync, make
schedule_snapshotrequest, and finally restart irreversible node.Test run in CICD for 3 times. No failure happened.
Resolves #846