Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ordered_diff tests to check that the diff result is not changing (as it is part of consensus) #924

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Oct 11, 2024

Resolves #701.

This PR adds a checker class which has a Print function to output the diff result in a form that can be used as an initializer. This was useful to generate the diff_result initializers we want to compare with.

@greg7mdp greg7mdp requested review from heifner and linh2931 October 11, 2024 14:58
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description. This one does not resolve #743, but #701.

@greg7mdp greg7mdp merged commit da3ce09 into main Oct 11, 2024
36 checks passed
@greg7mdp greg7mdp deleted the gh_743 branch October 11, 2024 18:46
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Internal
summary: Update ordered_diff tests to check the diff result is not changing.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional ordered_diff tests
4 participants