Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inbox not default screen when set as such #6168

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

liutng
Copy link
Contributor

@liutng liutng commented Oct 28, 2022

This PR closes #6167.

Fixes

  • Fixed the tag name of InboxFragment in accordance with its name in ListPreference so that InboxFragment could be named matched with its Preference Name and loaded in MainActivity::onCreate()

@keunes keunes changed the title Fixed Index Page can't be as default page. Fix Inbox not default screen when set as such Oct 28, 2022
@ByteHamster
Copy link
Member

Thanks for working on this. To be honest, I would rather change the settings screen, not the fragment tag. The reason is that stuff like launcher shortcuts depend on the tag. Would you be up for doing that?

@liutng
Copy link
Contributor Author

liutng commented Oct 28, 2022

Sure no problem, I'm working on that.

Changed IndexFragment tag in settings screen instead of the TAG of IndexFragment.
@liutng
Copy link
Contributor Author

liutng commented Oct 28, 2022

New commit pushed.

@ByteHamster ByteHamster merged commit a87d660 into AntennaPod:develop Oct 28, 2022
@ByteHamster
Copy link
Member

Nice, thanks!

@liutng
Copy link
Contributor Author

liutng commented Oct 31, 2022

My pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set Inbox page as default page
2 participants