[lint] lintrunner fixes/improvements (pytorch#68292)

Summary:
Pull Request resolved: pytorch#68292

- noqa was typo-d to be the same as type: ignore
- generalize clang-tidy initialization and use it for clang_format as well
- Add a script that lets you update the binaries in s3 relatively easily

Test Plan: Imported from OSS

Reviewed By: malfet

Differential Revision: D32403934

Pulled By: suo

fbshipit-source-id: 4e21b22605216f013d87d636a205707ca8e0af36

.gitignore

@@ -287,6 +287,7 @@ TAGS
 # clang tooling storage location
 .clang-format-bin
 .clang-tidy-bin
+.lintbin
 
 # clangd background index
 .clangd/

.lintrunner.toml

@@ -53,10 +53,19 @@ include_patterns = [
     'test/cpp/tensorexpr/**/*.h',
     'test/cpp/tensorexpr/**/*.cpp',
 ]
+init_command = [
+    'python3',
+    'tools/linter/adapters/s3_init.py',
+    '--config-json=tools/linter/adapters/s3_init_config.json',
+    '--linter=clang-format',
+    '--dry-run={{DRYRUN}}',
+    '--output-dir=.lintbin',
+    '--output-name=clang-format',
+]
 command = [
     'python3',
     'tools/linter/adapters/clangformat_linter.py',
-    '--binary=clang-format',
+    '--binary=.lintbin/clang-format',
     '--',
     '@{{PATHSFILE}}'
 ]
@@ -159,15 +168,17 @@ exclude_patterns = [
 ]
 init_command = [
     'python3',
-    'tools/linter/adapters/clangtidy_init.py',
-    '--dry_run={{DRYRUN}}',
-    '--output_dir=.clang-tidy-bin',
-    '--output_name=clang-tidy',
+    'tools/linter/adapters/s3_init.py',
+    '--config-json=tools/linter/adapters/s3_init_config.json',
+    '--linter=clang-tidy',
+    '--dry-run={{DRYRUN}}',
+    '--output-dir=.lintbin',
+    '--output-name=clang-tidy',
 ]
 command = [
     'python3',
     'tools/linter/adapters/clangtidy_linter.py',
-    '--binary=.clang-tidy-bin/clang-tidy',
+    '--binary=.lintbin/clang-tidy',
     '--build_dir=./build',
     '--',
     '@{{PATHSFILE}}'
@@ -198,8 +209,8 @@ exclude_patterns = ['caffe2/**']
 command = [
     'python3',
     'tools/linter/adapters/grep_linter.py',
-    '--pattern=# type:\s*ignore(?!\[)',
-    '--linter-name=TYPEIGNORE',
+    '--pattern=# noqa(?!: [A-Z]+\d{3})',
+    '--linter-name=NOQA',
     '--error-name=unqualified noqa',
     """--error-description=\
         This line has an unqualified `noqa`; \

tools/linter/adapters/clangformat_linter.py

@@ -7,6 +7,7 @@
 import sys
 import time
 from enum import Enum
+from pathlib import Path
 from typing import Any, List, NamedTuple, Optional
 
 
@@ -209,6 +210,23 @@ def main() -> None:
     )
 
     binary = os.path.normpath(args.binary) if IS_WINDOWS else args.binary
+    if not Path(binary).exists():
+        lint_message = LintMessage(
+            path=None,
+            line=None,
+            char=None,
+            code="CLANGFORMAT",
+            severity=LintSeverity.ERROR,
+            name="init-error",
+            original=None,
+            replacement=None,
+            description=(
+                f"Could not find clang-format binary at {binary}, "
+                "did you forget to run `lintrunner init`?"
+            ),
+        )
+        print(json.dumps(lint_message._asdict()), flush=True)
+        sys.exit(0)
 
     with concurrent.futures.ThreadPoolExecutor(
         max_workers=os.cpu_count(),