-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating static docs #1028
Updating static docs #1028
Conversation
@ATheorell and @AntonOsika I would love to get a review on this one so that we can get it merged. |
Great work, we are now down to only 3 warnings! That is a massive improvement. From my point of view, you could cut down on static docs even harder. In particular, I would kill the part about "customizing steps", which is outdated. I would probably also remove the part about the "core components" since they are relatively understandable in the API reference too, but this part is now correct so, it could also stay for now :) |
As requested in the meeting, here comes the full build log. I'm running Ubuntu 22 LTS $ make html The HTML pages are in _build/html. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
=======================================
Coverage ? 84.96%
=======================================
Files ? 25
Lines ? 1237
Branches ? 0
=======================================
Hits ? 1051
Misses ? 186
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Hi @ATheorell, thanks for your comment + sharing the output of the build. As followed your suggestion and removed:
Please let me know if there are other sections we should remove (e.g. windows setup, tracing and debugging). Regarding the three remaining warnings, its strange, some of the warnings you shared make references to files that have been renamed. I have pasted the output I see locally, clean of any errors. Do you see the same error if you:
|
Thanks for the fixes! I'm now left with 2 warnings /home/axel/Software/gpt-engineer-dev/docs/index.rst:20: WARNING: toctree contains reference to nonexisting document 'docs_building' ..and I also have a fix for it! There is a reference to docs_building.md, whereas the files is called DOCS_BUILDING.md in all caps. I guess that you are running windows? Unix is case sensitive. Renaming the file removes the warning. I will merge your PR and fix this myself. Thanks a lot for saving the docs. Now they are both useful and easy to maintain. |
This PR replaces #993 to address task 3 of this issue: #990
The focus of this PR is on: