Extend tests for DB class #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonOsika
reviewed
Jun 18, 2023
AntonOsika
reviewed
Jun 18, 2023
|
Thanks @Snoup97. I prefer pytest and was using it thus far. Do you think we could move to it? If you have a good reason, I'd be happy to merge like this too (and maybe change later). Please see my comment on not allowing arbitrary types, only str, when writing! |
Co-authored-by: Anton Osika <[email protected]>
|
@patillacode can you take a look at this? |
|
Looks good, haven't tested it locally though. before I test and approve please make sure you are running the |
|
Run ci and it should be good |
|
@patillacode should be good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.