Refactored by Sourcery AI #188
Conversation
Sourcery refactored main branch
| @@ -39,7 +39,7 @@ def fassistant(self, msg): | |||
|
|
|||
| def next(self, messages: list[dict[str, str]], prompt=None): | |||
| if prompt: | |||
| messages = messages + [{"role": "user", "content": prompt}] | |||
| messages += [{"role": "user", "content": prompt}] | |||
There was a problem hiding this comment.
Extending a list modifies the argument in python no?
There was a problem hiding this comment.
I believe both lines do exactly the same.
There was a problem hiding this comment.
They don't, += modifies the variable for the caller, the old code creates a new variable. I was testing this out while you merged lol:
def foo1(messages):
messages += ["role"]
def foo2(messages):
messages = messages + ["role"]
m1 = ["m1"]
foo1(m1)
print(m1)
m2 = ["m2"]
foo2(m2)
print(m2)This prints
['m1', 'role']
['m2']
There was a problem hiding this comment.
what python version?
There was a problem hiding this comment.
There was a problem hiding this comment.
Call them the other way around:
def foo1(messages):
messages += ["role"]
def foo2(messages):
messages = messages + ["role"]
m2 = ["m2"]
foo2(m2)
print(m2)
m1 = ["m1"]
foo1(m1)
print(m1)this prints:
['m2']
['m1', 'role']
There was a problem hiding this comment.
just opened a pr without +=
There was a problem hiding this comment.
Oops, copied the wrong output, yeah it was:
['m2']
['m1', 'role']
There was a problem hiding this comment.
Just to clarify
in foo1 we are modifying the messages variable given as parameter
in foo2 we are creating a new list and the original messages remains unchanged
In the actual code we are returning messages so it would be like adding a return in foo2 if you want to compare.
|
Extending a list modifies the argument in python no? Otherwise looks great and I’m happy to merge |
4 File changed with 9 Additions and 10 deletions