Langchain integration #466

hrobbins · 2023-07-02T02:42:19Z

Trying to keep things simple for this initial conversion to LangChain. The only difference with the original functionality is this version doesn't stream the output from OpenAI, so there is bit of a delay in waiting for the result.

This branch will enable using any LLM, from hugging-face, locally, any LangChain supported LLM service, such as Anthropic/Claude, or pointing it to a Custom LLM.

…sed for debugging

AntonOsika

Not 100% we want langchain in here:)

AntonOsika · 2023-07-02T12:32:40Z

gpt_engineer/ai.py

        logger.debug(f"Chat completion finished: {messages}")
        return messages

+    def lastMessageContent(self, messages):


python uses snake case

AntonOsika · 2023-07-02T12:33:13Z

gpt_engineer/ai.py

+            if messages and isinstance(messages, list) and len(messages) > 0:
+                r = json.dumps(messages_to_dict(messages))
+        except Exception as e:
+            logging.warn("Exception serializing messages, returning empty array", e)


This exception handling should not exist imo?

AntonOsika · 2023-07-02T12:33:19Z

gpt_engineer/learning.py

@@ -97,15 +98,19 @@ def logs_to_string(steps: List[Step], logs: DB):
    chunks = []
    for step in steps:
        chunks.append(f"--- {step.__name__} ---\n")
-        messages = json.loads(logs[step.__name__])
-        chunks.append(format_messages(messages))
+        # messages = json.loads(logs[step.__name__])


AntonOsika · 2023-07-02T12:35:16Z

Thanks @hrobbins for contributing to improving the repository!

I can see the case for being able to use other language models, but I think we can do that without langchain, and we want to keep it simple. Are there other advantages?

We only merge PRs that use python pep8, doesn't leave comments hanging around etc. So since this is not the focus right now, I will close the PR, but feel free to open it if you are committed to fixing everything and can argue for why we want langchain today.

AntonOsika · 2023-07-02T14:57:03Z

gpt_engineer/ai.py

+            self.chat = ChatOpenAI(model=self.modelid, temperature=temperature)
+        except Exception as e:
+            # ? try a different model
+            logging.warning(e)


Should not catch this error – it should raise!

AntonOsika · 2023-07-02T14:57:56Z

gpt_engineer/ai.py

        logger.debug(f"Chat completion finished: {messages}")
        return messages

+    def lastMessageContent(self, messages):
+        m = messages[-1].content
+        if m:


Doesn't need if statement here

AntonOsika · 2023-07-02T14:58:28Z

gpt_engineer/ai.py

+        return m
+
+    def serializeMessages(messages):
+        # dicts = messages_to_dict(history.messages)


AntonOsika · 2023-07-02T14:59:04Z

gpt_engineer/ai.py

+        # dicts = messages_to_dict(history.messages)
+        r = "[]"
+        try:
+            if messages and isinstance(messages, list) and len(messages) > 0:


AntonOsika · 2023-07-02T14:59:33Z

There is a lot of good stuff here so happy to reopen

…ep, asking for clarification

AntonOsika · 2023-07-06T21:08:54Z

@hrobbins thought more about it and I like many things here

would need to address the comments and make sure streaming is still working before we merge though.

Have you given up on this or are you up for the challenge?

UmerHA · 2023-07-07T11:31:34Z

@hrobbins if you don't have the time to do it, let me know - id be happy to do it!

need this to finish #431

(cc @AntonOsika)

hrobbins · 2023-07-07T13:26:19Z

Can probably polish it up today. Already made most of the recommended changes, looks like it just needs a callback handler for the streaming. For other reasons, I started working on breaking down the processes into more isolated requests to the LLM so each one is individually a smaller response anyway. Streaming is less important when we're not asking it to do everything at once with each call. But I can go ahead and re-add it.

…

-H

On Fri, Jul 7, 2023, 4:31 AM UmerHA ***@***.***> wrote: @hrobbins <https://github.com/hrobbins> if you don't have the time to do it, let me know - id be happy to do it! need this to finish #431 <#431> (cc @AntonOsika <https://github.com/AntonOsika>) — Reply to this email directly, view it on GitHub <#466 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGVMKNSEEQ2IT3WWP5KUDDXO7XSFANCNFSM6AAAAAAZ3E6INA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

UmerHA · 2023-07-07T14:38:40Z

Hey @hrobbins! Sorry, I was too eager 🙈 I had already implemented it before I saw your response.

Here's the branch: https://github.com/UmerHA/gpt-engineer/commits/langchain-integration.

Iiuc, the scope of this PR is to make it work for (i) LangChain models, (ii) HuggingFace models, and (iii) local models. I've done (i), so you could still do (ii) and (iii).

If you want, I can merge my code into yours?
Or should I open a PR instead?

Will do what you decide.

hrobbins · 2023-07-07T16:39:35Z

No worries, go for it.

…

-H

On Fri, Jul 7, 2023, 7:38 AM UmerHA ***@***.***> wrote: Hey @hrobbins <https://github.com/hrobbins>! Sorry, I was too eager 🙈 I had already implemented it before I saw your response. Here's the branch: https://github.com/UmerHA/gpt-engineer/commits/langchain-integration. Iiuc, the scope of this PR is to make it work for (i) LangChain models, (ii) HuggingFace models, and (iii) local models. I've done (i), so you could still do (ii) and (iii). If you want, I can merge my code into yours? Or should I open a PR instead? Will do what you decide. — Reply to this email directly, view it on GitHub <#466 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGVMKN5P6IPHSDFQNPNJKDXPANPZANCNFSM6AAAAAAZ3E6INA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

hrobbins · 2023-07-07T18:58:22Z

Hey @hrobbins! Sorry, I was too eager 🙈 I had already implemented it before I saw your response.

Here's the branch: https://github.com/UmerHA/gpt-engineer/commits/langchain-integration.

Iiuc, the scope of this PR is to make it work for (i) LangChain models, (ii) HuggingFace models, and (iii) local models. I've done (i), so you could still do (ii) and (iii).

If you want, I can merge my code into yours? Or should I open a PR instead?

Will do what you decide.

Reviewed what you did. Nicely done!

hrobbins added 5 commits June 30, 2023 19:24

Added LangChain integration

034a9a1

Fixed issue created by git checkin process

8987ba2

Added ':' to characters to remove from end of file path

d4ab42a

Tested initial migration to LangChain, removed comments and logging u…

c8ec10a

…sed for debugging

Tested initial migration to LangChain, removed comments and logging u…

b39505b

…sed for debugging

AntonOsika requested changes Jul 2, 2023

View reviewed changes

AntonOsika closed this Jul 2, 2023

AntonOsika mentioned this pull request Jul 2, 2023

Improvements #63

Closed

AntonOsika reviewed Jul 2, 2023

View reviewed changes

gpt_engineer/ai.py Outdated

return m

def serializeMessages(messages):

# dicts = messages_to_dict(history.messages)

Copy link

Owner

AntonOsika Jul 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

AntonOsika reviewed Jul 2, 2023

View reviewed changes

hrobbins added 5 commits July 2, 2023 19:27

Converted camelCase to snake_case

f7f9167

Turns out we need the exception handling

ee44a71

Testing Hugging Face Integrations via LangChain

b7d05d9

Added LangChain loadable models

52aabba

Renames "qa" prompt to "clarify", since it's used in the "clarify" st…

8015867

…ep, asking for clarification

AntonOsika reopened this Jul 6, 2023

UmerHA mentioned this pull request Jul 7, 2023

Langchain integration #512

Merged

AntonOsika closed this Jul 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Langchain integration #466

Langchain integration #466

hrobbins commented Jul 2, 2023

AntonOsika left a comment

AntonOsika Jul 2, 2023

AntonOsika Jul 2, 2023

AntonOsika Jul 2, 2023

AntonOsika commented Jul 2, 2023

AntonOsika Jul 2, 2023

AntonOsika Jul 2, 2023

AntonOsika Jul 2, 2023

AntonOsika Jul 2, 2023

AntonOsika commented Jul 2, 2023

AntonOsika commented Jul 6, 2023

UmerHA commented Jul 7, 2023

hrobbins commented Jul 7, 2023 via email

UmerHA commented Jul 7, 2023

hrobbins commented Jul 7, 2023 via email

hrobbins commented Jul 7, 2023

Langchain integration #466

Langchain integration #466

Conversation

hrobbins commented Jul 2, 2023

AntonOsika left a comment

Choose a reason for hiding this comment

AntonOsika Jul 2, 2023

Choose a reason for hiding this comment

AntonOsika Jul 2, 2023

Choose a reason for hiding this comment

AntonOsika Jul 2, 2023

Choose a reason for hiding this comment

AntonOsika commented Jul 2, 2023

AntonOsika Jul 2, 2023

Choose a reason for hiding this comment

AntonOsika Jul 2, 2023

Choose a reason for hiding this comment

AntonOsika Jul 2, 2023

Choose a reason for hiding this comment

AntonOsika Jul 2, 2023

Choose a reason for hiding this comment

AntonOsika commented Jul 2, 2023

AntonOsika commented Jul 6, 2023

UmerHA commented Jul 7, 2023

hrobbins commented Jul 7, 2023 via email

UmerHA commented Jul 7, 2023

hrobbins commented Jul 7, 2023 via email

hrobbins commented Jul 7, 2023