Docker And Docker-Compose Support #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: karlderkaefer <[email protected]>
|
I won't be able to test it out within next 2 weeks but the code looks good from my side |
|
Good job @ayoubfletcher and @karlderkaefer Keep the good work up . |
70ziko
pushed a commit
to 70ziko/gpt-engineer
that referenced
this pull request
Oct 25, 2023
* Added Docker support. * Fixed a typo. * Added .dockerignore * Update README.md Co-authored-by: karlderkaefer <[email protected]> --------- Co-authored-by: MurdieX <Ayoub Fletcher> Co-authored-by: karlderkaefer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem with the previous pull request I synced the fork and it forced the pull request to get close my bad.
The previous pull request has some issues that have been pointed out by karlderkaefer the suggested solution didn't work that well forcing the container to run using the current user id and group caused some issues with the code inside the container. But it has been fixed by forcing the owner to nobody after the code generated and most of the generated code seems to prefer Debian distro, so container is using the debian with sudo to run the generated code inside the container.