Rebase of @leomariga's Existing Project #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isspellings and cleaned up. Applied leomariga suggestions.
Added range functionality to file selector input, fixed some bugs, m…
…isspellings and cleaned up. Applied leomariga suggestions.
# Conflicts: # gpt_engineer/file_selector.py # gpt_engineer/main.py
…0, and a few common library folders are ignored (site-packages, and node_modules).
…tput format is correct and the regEx parser can pick up the file name and place the file correctly.
|
I think I have addressed everything in the last comments of #465. Additionally if the file names are not known or a new file is generated then these new files are placed in |
|
Thanks for helping us with this issue @pbharrin . I hope we can see it merged soon. =) |
|
Awesome great job @pbharrin I'll try to do the review later today, day full of afk duties. |
AntonOsika
reviewed
Aug 13, 2023
AntonOsika
requested changes
Aug 13, 2023
Remove development notes. Co-authored-by: Anton Osika <[email protected]>
Co-authored-by: Anton Osika <[email protected]>
Co-authored-by: Anton Osika <[email protected]>
remove redundant code Co-authored-by: Anton Osika <[email protected]>
remove development notes Co-authored-by: Anton Osika <[email protected]>
Co-authored-by: Anton Osika <[email protected]>
Co-authored-by: Anton Osika <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @AntonOsika I've rebased @leomariga 's "Improve Existing Codes" PR #465 to recent changes.
I tested and it works in "normal" mode (generate new code) and it works in Improve Existing Code mode. Existing code mode works for command line mode as well as the TKInter based GUI. I ran tests and they all passed (except test_ai.py which has nothing in it.)
I think there are some existing comments from the PR which could be implemented. I will check on those.