-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make gpt-engineer pip installable/runnable #60
Conversation
for reproducibility purposes
Co-authored-by: Anton Osika <[email protected]>
Co-authored-by: Anton Osika <[email protected]>
Example output (.venv) jeadie@Jacks-MBP gpt-engineer % gpt-engineer --help
Usage: gpt-engineer [OPTIONS] [PROJECT_PATH]
Arguments:
[PROJECT_PATH] path
Options:
--run-prefix TEXT run prefix, if you want to run multiple
variants of the same project and later
compare them
--model TEXT [default: gpt-4]
--temperature FLOAT [default: 0.1]
--install-completion [bash|zsh|fish|powershell|pwsh]
Install completion for the specified shell.
--show-completion [bash|zsh|fish|powershell|pwsh]
Show completion for the specified shell, to
copy it or customize the installation.
--help Show this message and exit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Jeadie
this looks great, although I left a couple of comments, only one requesting a change though.
couple of notes:
-
can you make sure you get rid of all those old commits? I think you branched out in a weird state maybe?
-
can you add the corresponding documentation to the
README.md
file?
I'll give this a go in the meantime.
EDIT:
I tried to run it, unsuccessfully.
It seems like running via the command doesn't work.
The error is this one:
FileNotFoundError: [Errno 2] No such file or directory: '/Users/dvitto/projects/gpt-engineer-jeadie-60/venv/lib/python3.11/site-packages/identity/qa'
Running with --help
gave the expected output but
I believe it could be related to what @AntonOsika mentioned here.
Also, I just noticed, the parameters are not being taken care of.
Meaning passing parameters are not taken into account at all, am I missing something?
Thanks a lot.
def __contains__(self, key): | ||
return (self.path / key).exists() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
from gpt_engineer.chat_to_files import to_files | ||
from gpt_engineer.ai import AI | ||
from gpt_engineer.steps import STEPS | ||
from gpt_engineer.db import DB, DBs | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also like this better, explicit and probably saving someone from a circular import dependency.
def execute(): | ||
app() | ||
|
||
|
||
if __name__ == "__main__": | ||
execute() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we just call app()
instead of execute()
and get rid of the execute
definition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is helpful for referencing it in pyproject.toml
I think it will be easier (and cleaner/best practice going forward) to squash and merge all contributions to have a more readable main branch. Making some improvements in a second PR, will QA again today. |
fix file path issue due to pip installables
Fixes are up. They were just due to how i was testing things initially. Having identity as a file is highly fragile. We will need to move off it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now working, thanks for the changes.
Two more things:
- can you squash your commits?
- parameters (i,e
--model
) are not being taken care of, I believe you left that on purpose, is this something you plan on adding?
I don't feel comfortable merging something that tells the user "use me like this" (when running gpt-engineer --help
) but it is not actually working unless we plan on adding it shortly.
I did not touch |
Feature
Make it easy to run
Changeset
gpt_engineer/
directory and move python files