Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre commit setup #61

Merged
merged 6 commits into from
Jun 17, 2023
Merged

Pre commit setup #61

merged 6 commits into from
Jun 17, 2023

Conversation

patillacode
Copy link
Collaborator

@patillacode patillacode commented Jun 16, 2023

Closes #57

Please find the necessary changes to setup pre-commit in the project.

Also, I added the .github/CONTRIBUTING.md file where the installation and usage of pre-commit is explained in detail along side some other information regarding contributions.

@patillacode patillacode requested a review from AntonOsika June 16, 2023 01:14
@patillacode patillacode mentioned this pull request Jun 16, 2023
@@ -0,0 +1,112 @@
# Contributing to GPT Engineer

By participating in this project, you agree to abide by the [code of conduct](CODE_OF_CONDUCT.md).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware that we don't have a CODE_OF_CONDUCT.md file yet.
See #48

@patillacode
Copy link
Collaborator Author

@AntonOsika please give this a go, I would like your approval before I merge!

Let me know if you have any feedback.

@patillacode patillacode self-assigned this Jun 16, 2023
@AntonOsika
Copy link
Owner

Looks good to me!

Good job @patillacode

@AntonOsika AntonOsika merged commit 14a6fa3 into main Jun 17, 2023
@AntonOsika
Copy link
Owner

AntonOsika commented Jun 18, 2023 via email

@patillacode
Copy link
Collaborator Author

Hi @AntonOsika

I'd recommend you pull the latest main and run make dev-install
This will reset your venv, reinstalling requirements and installing pre-commit

Alternatively, you can just make sure all requirements are installed and run pre-commit install

Automatically you will get the hooks when doing any commit.

Please let me know if this is working for you, also, there is documentation on how to install and a running example in CONTRIBUTING.md

@patillacode patillacode deleted the pre-commit-setup branch June 18, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pre-commit
2 participants