-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding official agent protocol test to ci + github badge #698
Conversation
Is there an obvious reason why neither the ci.yaml, nor validate_agent_protocol.yml are run in the checks? They are the whole purpose with this PR. Again asking for help, @k1lgor, since you've been involved in setting up the ci. |
I can reproduce this failure locally and it is because the OPENAI_API_KEY is not defined. Long term, it would be nice to have some kind of dummy model that could be used. For now, the easy fix is to add the api key to github as a secret, once that is done, the action script should already be reading from it. Would be great if you could do this @AntonOsika https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions (I don't have permission). Call the secret OPENAI_API_KEY And while your at it, feel free to add a codecov.io token as a secret too, which will enable us to monitor test coverage. |
This is currently failing because pip install agent-protocol is down. Waiting til they get it up again. |
Now all tests are passing. I took the freedom to make a further update and use tempdir as the default for hosting the tasks. Let me know if this has any clear disadvantages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, very professional cleanup.
No description provided.