Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile #80

Merged
merged 6 commits into from
Jun 18, 2023
Merged

Makefile #80

merged 6 commits into from
Jun 18, 2023

Conversation

patillacode
Copy link
Collaborator

@patillacode patillacode commented Jun 16, 2023

By using a Makefile we can abstract some of the things needed to run the app or install it and it is a great place for future commands (like testing)

See a demo below:
asciicast

@patillacode patillacode self-assigned this Jun 16, 2023
@patillacode patillacode added the enhancement New feature or request label Jun 16, 2023
@jebarpg
Copy link
Contributor

jebarpg commented Jun 17, 2023

So I also see a lot of projects us a bat file in addition to a makefile to do installations. What are your thoughts about creating a batch file to run and install?

@patillacode
Copy link
Collaborator Author

Sounds good to me although I am not familiar with those, we can add that one in another PR.

I believe .bat files are for Windows, right?

@patillacode patillacode mentioned this pull request Jun 17, 2023
@patillacode patillacode marked this pull request as ready for review June 17, 2023 15:36
@patillacode
Copy link
Collaborator Author

patillacode commented Jun 17, 2023

@AntonOsika @FOLLGAD

WDYT?

If you would like to have something like this let me know and I will amend the README for it

I would suggest having two way of installing, classic python way (like it is now in the docs) but also the make way which abstracts things a bit and makes them easier for non pythonistas.

@AntonOsika
Copy link
Owner

Thanks @patillacode!

I looked yesterday and wanted to ask, do you want to put black commands and pytest commands in here?

Or do you have a simple command to run all the tools in pyproject.toml you prefer?

@AntonOsika
Copy link
Owner

Also my only concern with Makefiles...

If we change how things are run, we have to keep Makefile in sync.

(And it makes it "harder to find things" since there are so many files)

@AntonOsika AntonOsika merged commit 4b093cb into main Jun 18, 2023
@patillacode
Copy link
Collaborator Author

Thanks @AntonOsika

  • Yes, sometimes it is a bit hard to maintain if we don't keep it simple.
    I'd say for now just using the Makefile as an alternative to installing would be enough.

  • As for running black for example, I leave that to the pre-commit hooks, I don't think we need a make black command to run black

  • For running tests, yes, we should add a tests command so when you do make tests it runs them.

  • I will edit the README.md so people know there is now a Makefile that they can use to install and run the project

@patillacode patillacode deleted the add-makefile branch June 18, 2023 11:42
@shubham-attri
Copy link
Contributor

@patillacode @AntonOsika I can document the makefile because it is very crucial step in setting up the codebase for development and a proper documentation is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants