Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move API to using glob patterns #32

Merged
merged 4 commits into from
Dec 24, 2019

Conversation

ojizero
Copy link
Contributor

@ojizero ojizero commented Dec 24, 2019

This allows for further customization of report file names, fixes #10.

It also upgrades officially supported (and tested against) Node version to 10.0.0.

ojizero added 2 commits December 24, 2019 11:51
BREAKING CHANGE: old API (reportDir and rootDir) has been dropped in favour of the new Glob patterns allowing further configurability for report file names
…Node 8 reaches it's EOL

BREAKING CHANGE: drops support for 10.0.0 > Node >= 8.6.0
@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #32   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          28     24    -4     
  Branches        1      2    +1     
=====================================
- Hits           28     24    -4
Impacted Files Coverage Δ
lib/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbde9d...8cf497b. Read the comment docs.

Copy link
Owner

@Antontelesh Antontelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for this PR. Could you update readme as well?

tests/merge.js Show resolved Hide resolved
@ojizero
Copy link
Contributor Author

ojizero commented Dec 24, 2019

@Antontelesh just updated the readme file, sorry completely forgot about it when I made the PR

@Antontelesh Antontelesh merged commit 5488967 into Antontelesh:master Dec 24, 2019
@Antontelesh
Copy link
Owner

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report filenames should be configurable
2 participants