add support for yabsnap snapshot information

[64-bitman]

Yabsnap is equivalent to OpenSUSE's snapper but made for Arch Linux

This PR adds support for parsing the information from the json metadata files that yabsnap uses to track comments and triggers (type). There is no set name for the metadata files, its just the name of the snapshot + "-meta.json", and the files are located in the same directory where its respective snapshot lives

[Schievel1]

Could you also edit the Readme a bit and mention this new program we support? Have you also tested how grub-btfsd behaves with yabsnap? If it's the same like snapper, e.g. keeping all the snapshots in /.snapshots, or any other directory, that is just there and does not disappear, this should work right out of the box. Timeshift does a few very special things.

[64-bitman]

Have you also tested how grub-btfsd behaves with yabsnap?

Yes and it works fine on my end, its very similar to snapper

[64-bitman]

I think this PR is ready now

[Schievel1]

thank you very much for your contribution

[alexindigo]

@Schievel1 looks like pacman still doesn't have this change, do you know what needs to be done to propagate this change to pacman?
Thank you.

[alexindigo]

Looks like it's pretty old version:

sudo grub-btrfsd --version
[!] Unknown option --version

[?] Usage:
grub-btrfsd [-h, --help] [-c, --no-color] [-l, --log-file LOG_FILE] [-r, --recursive] [-s, --syslog] [-t, --timeshift-auto] [-v, --verbose] SNAPSHOTS_DIRS

SNAPSHOTS_DIRS         Snapshot directories to watch, without effect when --timeshift-auto

Optional arguments:
-c, --no-color        Disable colors in output
-l, --log-file        Specify a logfile to write to
-r, --recursive       Watch snapshots directory recursively
-s, --syslog          Write to syslog
-o, --timeshift-old   Look for snapshots in directory of Timeshift <v22.06 (requires --timeshift-auto)
-t, --timeshift-auto  Automatically detect Timeshifts snapshot directory
-v, --verbose         Let the log of the daemon be more verbose
-h, --help            Display this message

Version 4.12-master-2023-04-28T16:26:00+00:00

[alexindigo]

Hey @Schievel1 @maximbaz

Looks like neither pacman nor aur version (https://aur.archlinux.org/cgit/aur.git/log/?h=grub-btrfs-git) have this changes, not sure what needs to be done to have this change in.

[maximbaz]

AUR package grub-btrfs-git pulls the latest code from this repo, so I'm not sure what you are referring to...

[Schievel1]

What maximbaz said. But nevertheless, maybe it's time for a new release to get this into the versioned packages.

[alexindigo]

@maximbaz I see, I got confused by commits listed in AUR package page.

Any plans/blockers to "release" this change to the main package?

[maximbaz]

I think it's up to maintainers, I'm not really involved in this project at the moment 😊 I'm also not the maintainer of the Arch package anymore.