Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ammr test upd #42

Merged
merged 47 commits into from
Jan 31, 2025
Merged

feat: Ammr test upd #42

merged 47 commits into from
Jan 31, 2025

Conversation

bkje14
Copy link
Contributor

@bkje14 bkje14 commented Jan 8, 2025

AMMR Test updates

Highlights

Smaller restructure in Tests

  • Kinematics folder with kinematic tests
  • Refactored body part tests into Body folder
  • Renamed and merged body part folders.
  • grouped GUI template tests

BodyModel refactors:

  • Added dummy folders for the new Data structure in arms and leg models.

Calibration specific changes:

  • Refactored calibration tests into Calibration folder
    • Added Trunk calibration test file.
      • BugFix: Fixed existing 2par calibration study for trunk - the existing study was not tested and did not work in some BM configs.
      • Updated some muscle models to stay as simple models even when 3E is enabled - data repo pr is here - some muscles do not have a range of motion and therefore cant be 3E muscles.
    • Currently excluded the lower_body calibration as it depends on a newer AMS 8.1 version - the test uses new AnyScript functions that are not present in the 8.1 beta used for testing.
    • The calibration studies for the lower body is refactored into a new interface that builds on Range Of Motion.
    • The each body region has a Range of Motion defined which by default is used as calibration positions.
    • The calibration folder now has a subfolder for Rmin and Rmax values to be used in the studies.

@bkje14 bkje14 changed the title Ammr test upd feat: Ammr test upd Jan 8, 2025
@bkje14 bkje14 marked this pull request as ready for review January 15, 2025 12:15
@bkje14 bkje14 requested a review from melund January 15, 2025 12:15
@melund
Copy link
Member

melund commented Jan 23, 2025

@bkje14. I think the "link check" test failure will be fixed if you merge from "AMMR4-beta"

@melund
Copy link
Member

melund commented Jan 27, 2025

@bkje14, is this ready to get merged? What is the status?

@bkje14
Copy link
Contributor Author

bkje14 commented Jan 31, 2025

Yes, I would like it merged before doing more restructure and calibration updates.

@melund melund merged commit 575d49f into ammr4-beta Jan 31, 2025
26 checks passed
@melund melund deleted the ammr-test-upd branch January 31, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants