Achilles tendon wrapping 2 #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@depierie Here is branch on top of this one, which have your calibration work and the custom tibial rotation: |
Co-authored-by: Enrico De Pieri <[email protected]>
melund
force-pushed
the
achilles-tendon-wrapping-2
branch
from
bc6fdea to
ab5671d
Compare
melund
commented
Apr 20, 2023
CHANGELOG.md
Outdated
Comment on lines
52
to
58
| * Wrapping surfaces have been added to the achilles tendon around the ankle in | ||
| the TLEM 2.0 leg model. This ensures a even ratio of moment arms between | ||
| the soleus and gastrocnemius muscles. Hence, gastroc is recruited less in | ||
| especially downhill walking, solving the models tendency to overpredict the | ||
| knee contact forces at toe off. This is the first of a number of improvements | ||
| to the leg model by Dr. Enrico De Pieri who is working on a | ||
| publication on improvements and validation of the TLEM 2 leg model. |
There was a problem hiding this comment.
@depierie I have added a entry to the changelog. Is this OK, otherwise just let me know what to write instead
depierie
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@depierie I made a new PR with a cleaned-up version of #766
I have removed the extra calibration and custom tibial rotation. That should probably have its own PR.
I have made the improvements exclusive to TLEM-2.0. I think that is best. It will limit the amount of validation we will have to do.