Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update deps and tests, fix a typo #30

Merged
merged 4 commits into from
Mar 23, 2024

Conversation

shuhuiluo
Copy link
Contributor

No description provided.

This commit includes updates to the package dependencies including `@openzeppelin/contracts`, `solady`, `prettier` and `typescript`. It also adjusts the `forge snapshot` and `forge snapshot:diff` commands in the test configuration to use the `cancun` EVM version and to isolate execution. Furthermore, the package version has been incremented.
Several test function definitions in `NPMCaller.t.sol`, `BitMath.t.sol`, `FullMath.t.sol` and `Base.t.sol` were updated. They were changed from `public` to either `public view` or `public pure` to correctly reflect that they don't modify any state. This will help prevent confusion during code reviews and audits.
Copy link
Contributor

@gnarlycow gnarlycow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Shuhui!

@gnarlycow gnarlycow merged commit 55629be into Aperture-Finance:main Mar 23, 2024
1 of 2 checks passed
@shuhuiluo shuhuiluo deleted the chore(deps) branch March 23, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants