perf: Optimize SafeCast and test TernaryLib
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes new test cases for the TernaryLib contract. It tests all the contract's methods with typical and edge cases to ensure they function as expected. Key functionalities include absolute difference, minimum and maximum values, switch conditions, and numerical sorting.
Changed variable naming convention, adjusted downcasting functions, and simplified type casting processes. Removed excess variables and optimized the functions by using direct returns. This improves the performance and maintainability of the library.
shuhuiluo
changed the title
SafeCast and test TernaryLibSafeCast and test TernaryLib
|
@gnarlycow Ptal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.