JSON schema compatibility rule bug: Remove an optional field should be backward compatible not full compatible

[shionefaye]

It is tested with the code in at this commit.

"original": {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "postal_code": {
      "type": "number"
    },
    "street": {
      "type": "string"
    }
  }
},
"updated": {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "street": {
      "type": "string"
    }
  }
}

[blacktooth]

Hello shionefaye,

Can you please share the code / test results that you tested this with?

[jsenko]

Hello @shionefaye ,
I've run your test case and it works as expected. Please share more info (as @blacktooth mentioned) or I'll have to close this issue. Thanks!
See https://github.com/jsenko/apicurio-registry/tree/tmp1

[shionefaye]

Hi blacktooth and jsenko,

Thanks for the timely response. I tested the with the latest change in the master branch.

Now I run the test with with tmp1 branch. The issues I reported in this and #1443 is gone. But a new issue emerges

The following change is backward compatible only.

"original": {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "postal_code": {
      "type": "number"
    }
  },
  "additionalProperties": {
    "type": "number"
  }
},
"updated": {
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "postal_code": {
      "type": "number"
    },
    "street": {
      "type": "number"
    }
  },
  "additionalProperties": {
    "type": "number"
  }
}

Backward Difference: [Difference(diffType=OBJECT_TYPE_PROPERTY_SCHEMAS_MEMBER_ADDED, pathOriginal=, pathUpdated=/properties, subSchemaOriginal=null, subSchemaUpdated=street)]
Foward Difference: []