feat(Editor): Add deprecated support #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricWittmann
requested changes
Apr 6, 2020
...c/app/pages/apis/{apiId}/editor/_components/forms/path/operation/info-section.component.html
Outdated
Show resolved
Hide resolved
...src/app/pages/apis/{apiId}/editor/_components/forms/path/operation/info-section.component.ts
Show resolved
Hide resolved
front-end/studio/src/app/pages/apis/{apiId}/editor/_services/rest-resource.service.ts
Outdated
Show resolved
Hide resolved
|
Hey @aoudiamoncef the maven build is failing for this. If you get a chance can you have a look? If not I'll get to it when I can. FYI the build is less permissive than the UI dev server, so sometimes the build will fail even if everything seems to work at dev time. :) |
|
Hi @EricWittmann, |
|
OK I'll try it out locally. |
|
OK I found the problem. You had removed the single-quotes from that one attribute in the template, but kept the square braces. No worries - I've fixed it and will merge soon. |
|
All done, thanks for the contribution @aoudiamoncef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @EricWittmann
Please don't laugh, i' definitely not a front-end developer. Don't hesitate to give me some feedbacks about this feature.