Use fluid layout #123
Merged
Use fluid layout #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for waiting so long for the merge, I will fix the travis and continue with reviews. |
|
Hello? :) |
|
@Nerian Merged after more than 2 years 🎉. I don't see big difference but looks like the fluid layout looks better on mobile phones. We will see if it breaks something but I hope not. Most of the users use custom layout anyway. Your pull request just deserved to be merged;). |
|
Merged in #409 |
| </head> | ||
| <body> | ||
| <div class="container-fluid"> | ||
| <div class="row-fluid"> |
There was a problem hiding this comment.
Well this bit is deprecated now. It should be row instead of row-fluid. :)
There was a problem hiding this comment.
Oh never mind, the bootstrap included is version 2, for which this syntax is correct.
There was a problem hiding this comment.
Yup I'm not going to update bootstrap version at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull changes the basic layout to a fluid one. This fixes a problem in 0.0.21 where the contents appear misplaced.