Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support response validation #619

Merged
merged 6 commits into from
May 16, 2018

Conversation

abenari
Copy link
Contributor

@abenari abenari commented May 8, 2018

This pull request contains 3 patches:

  1. Add support for response validation.
    With this patch it is easy to validate the response in unit tests with the documentation schema.
    It help creating and maintaining a valid response documentation.

  2. Supporting specification of array properties with non-string types

  3. Allows creating a schema where objects are defined once and referenced by multiple methods.
    When generating a client from the schema, the client code becomes easier to use.

elasti-ron added 2 commits May 9, 2018 01:45
…l_spec

moved "match_field_structure" matcher into swagger_dsl_spec (the only spec using it)
all specs pass
@iNecas
Copy link
Member

iNecas commented May 11, 2018

Looks promising. Would you mind updating the README to describe the new functionality?


require 'apipie/rspec/response_validation_helper'

RSpec.describe MyController, :type => :controller, :show_in_doc => true do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing indentation and final end for this block.

@abenari abenari force-pushed the support_response_validation branch from 5d8b2dd to da3b67a Compare May 15, 2018 15:22
@abenari
Copy link
Contributor Author

abenari commented May 16, 2018

fixed response validation description to the readme file

@iNecas
Copy link
Member

iNecas commented May 16, 2018

Thanks @abenari

@iNecas iNecas merged commit e2e5744 into Apipie:master May 16, 2018
@iNecas
Copy link
Member

iNecas commented Jun 29, 2018

Apipie-rails-0.5.9 with this change has been pushed to Rubygems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants