-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support response validation #619
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l_spec moved "match_field_structure" matcher into swagger_dsl_spec (the only spec using it) all specs pass
Looks promising. Would you mind updating the README to describe the new functionality? |
iNecas
reviewed
May 14, 2018
|
||
require 'apipie/rspec/response_validation_helper' | ||
|
||
RSpec.describe MyController, :type => :controller, :show_in_doc => true do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing indentation and final end
for this block.
5d8b2dd
to
da3b67a
Compare
fixed response validation description to the readme file |
Thanks @abenari |
Apipie-rails-0.5.9 with this change has been pushed to Rubygems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains 3 patches:
Add support for response validation.
With this patch it is easy to validate the response in unit tests with the documentation schema.
It help creating and maintaining a valid response documentation.
Supporting specification of array properties with non-string types
Allows creating a schema where objects are defined once and referenced by multiple methods.
When generating a client from the schema, the client code becomes easier to use.