PR comments

App-vNext · Jun 16, 2023 · 58b662a · 58b662a
1 parent 2f7fe4a
commit 58b662a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/samples/GenericStrategies/Program.cs b/samples/GenericStrategies/Program.cs
@@ -16,14 +16,15 @@
     {
         FallbackAction = async _ =>
         {
-            await Task.Yield();
+            await Task.Delay(10);
 
-            // return fallback result
+            // Return fallback result
             return new Outcome<HttpResponseMessage>(new HttpResponseMessage(System.Net.HttpStatusCode.OK));
         },
         // You can also use switch expressions for succinct syntax
         ShouldHandle = outcome => outcome switch
         {
+            // The "PredicateResult.True" is shorthand to "new ValueTask<bool>(true)"
             { Exception: HttpRequestException } => PredicateResult.True,
             { Result: HttpResponseMessage response } when response.StatusCode == HttpStatusCode.InternalServerError => PredicateResult.True,
             _ => PredicateResult.False
@@ -35,9 +36,8 @@
         ShouldRetry = outcome =>
         {
             // We can handle specific result
-            if (outcome.Result?.StatusCode == System.Net.HttpStatusCode.InternalServerError)
+            if (outcome.Result?.StatusCode == HttpStatusCode.InternalServerError)
             {
-                // The "PredicateResult.True" is shorthand to "new ValueTask<bool>(true)"
                 return PredicateResult.True;
             }
 
@@ -66,7 +66,8 @@
 var response = await strategy.ExecuteAsync(
     async token =>
     {
-        await Task.Yield();
+        await Task.Delay(10);
+        // This causes the action fail, thus using the fallback strategy above
         return new HttpResponseMessage(HttpStatusCode.InternalServerError);
     },
     CancellationToken.None);

diff --git a/samples/Intro/Program.cs b/samples/Intro/Program.cs
@@ -22,13 +22,13 @@
 strategy.Execute(() => { });
 
 // Asynchronously
-await strategy.ExecuteAsync(async token => { await Task.Yield(); }, CancellationToken.None);
+await strategy.ExecuteAsync(async token => { await Task.Delay(10); }, CancellationToken.None);
 
 // Synchronously with result
 strategy.Execute(token => "some-result");
 
 // Asynchronously with result
-await strategy.ExecuteAsync(async token => { await Task.Yield(); return "some-result"; }, CancellationToken.None);
+await strategy.ExecuteAsync(async token => { await Task.Delay(10); return "some-result"; }, CancellationToken.None);
 
 // Use state to avoid lambda allocation
 strategy.Execute(static state => state, "my-state");
@@ -53,7 +53,7 @@
             return PredicateResult.False;
         },
         // Register user callback called whenever retry occurs
-        OnRetry = _ => { Console.WriteLine("Retrying..."); return default; },
+        OnRetry = args => { Console.WriteLine($"Retrying...{args.Arguments.Attempt} attempt"); return default; },
         BaseDelay = TimeSpan.FromMilliseconds(400),
         BackoffType = RetryBackoffType.Constant,
         RetryCount = 3