Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Deterministic=true #1126

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Specify Deterministic=true #1126

merged 3 commits into from
Apr 14, 2023

Conversation

martincostello
Copy link
Member

Enable deterministic builds to try and resolve #1122.

Enable deterministic builds to try and resolve #1122.
@martincostello
Copy link
Member Author

Hmm...that didn't seem to fix it either.

image

Will have to break out the MSBuild binary logs to trace it and see what's happening.

- Fix deterministic builds.
- Bump version to 8.0.0 as #1121 failed.
Ignore `.binlog` files.
@martincostello
Copy link
Member Author

Looks good now.

image

@martincostello martincostello marked this pull request as ready for review April 14, 2023 14:45
@martincostello martincostello merged commit a4ec74e into main Apr 14, 2023
@martincostello martincostello deleted the enable-deterministic branch April 14, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CI builds are not deterministic
2 participants