-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize the callback API #1137
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1137 +/- ##
==========================================
+ Coverage 78.14% 78.48% +0.33%
==========================================
Files 201 204 +3
Lines 4846 4922 +76
Branches 863 869 +6
==========================================
+ Hits 3787 3863 +76
Misses 854 854
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Details on the issue fix or feature implementation
This PR finalizes and cleans-up the callback API.
NoOutcomeGenerator
and droppingTimeoutGenerator
TResult
based class for Generators and EventsResilienceStrategyOptions<TResult>
are introduced. The user will use these when they care only about specific result type. These can be easily converted toResilienceStrategyOptions
.I hope with this PR the callback API is almost done only minor changes (if any) will be done later.
Confirm the following