-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce unit-tests for issues fixed in v8 #1157
Conversation
04df38e
to
24da83e
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1157 +/- ##
==========================================
+ Coverage 83.03% 83.49% +0.45%
==========================================
Files 272 272
Lines 6183 6355 +172
Branches 1006 1018 +12
==========================================
+ Hits 5134 5306 +172
Misses 844 844
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I think we can just merge this PR and keep the branch. It just adds more tests which is useful to have in main. |
Details on the issue fix or feature implementation
Here we add unit tests for issues addressed in v8. This demonstrates the issue reporters the problem is fixed in v8.
Confirm the following