Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce unit-tests for issues fixed in v8 #1157

Merged
merged 12 commits into from
May 2, 2023
Merged

Introduce unit-tests for issues fixed in v8 #1157

merged 12 commits into from
May 2, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Apr 25, 2023

Details on the issue fix or feature implementation

Here we add unit tests for issues addressed in v8. This demonstrates the issue reporters the problem is fixed in v8.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Merging #1157 (959fe43) into main (2d47e4f) will increase coverage by 0.45%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
+ Coverage   83.03%   83.49%   +0.45%     
==========================================
  Files         272      272              
  Lines        6183     6355     +172     
  Branches     1006     1018      +12     
==========================================
+ Hits         5134     5306     +172     
  Misses        844      844              
  Partials      205      205              
Flag Coverage Δ
macos ?
windows 83.49% <100.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Core/Hedging/Controller/HedgingExecutionContext.cs 100.00% <100.00%> (ø)
src/Polly.Core/Hedging/Controller/TaskExecution.cs 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

@martintmk martintmk marked this pull request as ready for review May 2, 2023 08:09
@martintmk
Copy link
Contributor Author

I think we can just merge this PR and keep the branch. It just adds more tests which is useful to have in main.

@martincostello martincostello added the v8 Issues related to the new version 8 of the Polly library. label May 2, 2023
@martincostello martincostello added this to the v8.0.0 milestone May 2, 2023
@martintmk martintmk enabled auto-merge (squash) May 2, 2023 08:24
@martintmk martintmk merged commit 7ccf2e7 into main May 2, 2023
@martintmk martintmk deleted the v8-fixed-issues branch May 2, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants