Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AddResilienceStrategy API #1183

Merged
merged 1 commit into from
May 15, 2023
Merged

Improve AddResilienceStrategy API #1183

merged 1 commit into from
May 15, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented May 15, 2023

Details on the issue fix or feature implementation

While playing with the DI API I got bothered by the need to access the builder as context.Builder. This PR allows accessing the builder directly so instead of:

services.AddResilienceStrategy("myKey", context => context.Builder.AddTimeout());

We can now do:

// simple case
services.AddResilienceStrategy("myKey", builder => builder.AddTimeout());

// builder + context
services.AddResilienceStrategy("myKey", (builder, context) => builder.AddTimeout());

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk self-assigned this May 15, 2023
@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 15, 2023
@martintmk martintmk added this to the v8.0.0 milestone May 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #1183 (c39f67e) into main (cb017af) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files         273      273           
  Lines        6328     6329    +1     
  Branches     1028     1028           
=======================================
+ Hits         5279     5280    +1     
  Misses        844      844           
  Partials      205      205           
Flag Coverage Δ
linux ?
macos 83.42% <100.00%> (+<0.01%) ⬆️
windows 83.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ependencyInjection/AddResilienceStrategyContext.cs 100.00% <100.00%> (ø)
...tion/ConfigureResilienceStrategyRegistryOptions.cs 100.00% <100.00%> (ø)
...dencyInjection/PollyServiceCollectionExtensions.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 79c216a into main May 15, 2023
@martintmk martintmk deleted the mtomka/improve-di-api branch May 15, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants