Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use delegates in RetryStrategyOptions #1214

Merged
merged 3 commits into from
May 24, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented May 24, 2023

The issue or feature being addressed

Contributes to #1211.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 24, 2023
@martintmk martintmk added this to the v8.0.0 milestone May 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #1214 (b6530f0) into main (15473aa) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
+ Coverage   83.93%   83.99%   +0.06%     
==========================================
  Files         280      280              
  Lines        6528     6555      +27     
  Branches     1034     1036       +2     
==========================================
+ Hits         5479     5506      +27     
  Misses        844      844              
  Partials      205      205              
Flag Coverage Δ
linux ?
macos 83.99% <100.00%> (?)
windows 83.99% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/Polly.Core/Strategy/OutcomeGenerator.TResult.cs 100.00% <ø> (ø)
src/Polly.Core/Retry/RetryResilienceStrategy.cs 100.00% <100.00%> (ø)
.../Retry/RetryResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
...c/Polly.Core/Retry/RetryStrategyOptions.TResult.cs 100.00% <100.00%> (ø)
src/Polly.Core/Retry/RetryStrategyOptions.cs 100.00% <100.00%> (ø)

@martintmk martintmk enabled auto-merge (squash) May 24, 2023 08:50
@martintmk martintmk merged commit 3585867 into main May 24, 2023
@martintmk martintmk deleted the mtomka/use-delegates-in-retries branch May 24, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants