Simple cleanup #1219
Simple cleanup #1219
Conversation
| @@ -58,7 +58,7 @@ public TimeoutResilienceStrategy(TimeoutStrategyOptions options, TimeProvider ti | |||
| _cancellationTokenSourcePool.Return(cancellationSource); | |||
|
|
|||
| // check the outcome | |||
| if (outcome.Exception is OperationCanceledException e && isCancellationRequested && !previousToken.IsCancellationRequested) | |||
| if (isCancellationRequested && outcome.Exception is OperationCanceledException e && !previousToken.IsCancellationRequested) | |||
There was a problem hiding this comment.
Check the boolean first as it avoids the need for a type check in the majority of cases.
martincostello
added
the
v8
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1219 +/- ##
==========================================
- Coverage 82.63% 82.63% -0.01%
==========================================
Files 263 263
Lines 6042 6040 -2
Branches 971 970 -1
==========================================
- Hits 4993 4991 -2
Misses 844 844
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@martincostello I don't know why the code-ql check failed, seems like a CI issue. Can you advise? |
|
I'm not sure, I just see a load of compiler errors (and then the GitHub app crashed...). I've just told it to re-run in case it was some random transient thing. If it still fails I'll take a look tomorrow. |
The issue or feature being addressed
Details on the issue fix or feature implementation
Confirm the following