Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResilienceStrategyRegistry now uses context to configure the builder #1242

Merged
merged 1 commit into from
May 31, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented May 31, 2023

Details on the issue fix or feature implementation

Having just key as a parameter when configuring the builder was not enough and could cause some compatibility issues in the future. Using context is future-proof and allows us to add new members without breaking changes.

I have also fixed the order inconsistency; the builder is first followed by context in the provided callback.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 31, 2023
@martintmk martintmk added this to the v8.0.0 milestone May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #1242 (95c903c) into main (2b7fbf2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1242   +/-   ##
=======================================
  Coverage   82.79%   82.79%           
=======================================
  Files         264      265    +1     
  Lines        6096     6096           
  Branches      966      966           
=======================================
  Hits         5047     5047           
  Misses        844      844           
  Partials      205      205           
Flag Coverage Δ
linux 82.79% <100.00%> (ø)
macos 82.79% <100.00%> (ø)
windows 82.79% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Polly.Core/Registry/ConfigureBuilderContext.cs 100.00% <100.00%> (ø)
...ore/Registry/ResilienceStrategyRegistry.TResult.cs 100.00% <100.00%> (ø)
.../Polly.Core/Registry/ResilienceStrategyRegistry.cs 100.00% <100.00%> (ø)
...ependencyInjection/AddResilienceStrategyContext.cs 100.00% <100.00%> (ø)
...dencyInjection/PollyServiceCollectionExtensions.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 4ec50a9 into main May 31, 2023
@martintmk martintmk deleted the mtomka/registry-uses-context-to-configure-builders branch May 31, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants