-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dynamic reloads #1254
Merged
Merged
Enable dynamic reloads #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d88c71c
to
7959083
Compare
Codecov Report
@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
+ Coverage 83.12% 83.28% +0.16%
==========================================
Files 269 270 +1
Lines 6239 6299 +60
Branches 976 978 +2
==========================================
+ Hits 5186 5246 +60
Misses 844 844
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7959083
to
62375c0
Compare
@martincostello , anything left to address here? |
martincostello
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
Closes #1241
Details on the issue fix or feature implementation
This PR adds opt-in support for reloadable pipelines. Dynamic reloads are enabled when new
ConfigureBuilderContext.EnableReloads
method is called.Caller needs to provide a factory that returns a
CancellationToken
. When the token is cancelled the strategy is reloaded.I have also considered using
IChangeToken
which is more natural to propagate changes, however, we would have to add a new dependency toMicrosoft.Extensions.Primitives
which seemed overkill for such small addition.Confirm the following