Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop some convienience extensions #1283

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 13, 2023

Details on the issue fix or feature implementation

Dropping some convenience extensions. Mostly the cases when they accepted event callbacks. It's better to just use options for these cases.

Leaving the simple ones, that are good for demos and one-liner showcase of Polly V8.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 13, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #1283 (2e8dfeb) into main (53e01a8) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
- Coverage   83.41%   83.25%   -0.16%     
==========================================
  Files         263      263              
  Lines        6348     6290      -58     
  Branches      993      993              
==========================================
- Hits         5295     5237      -58     
  Misses        844      844              
  Partials      209      209              
Flag Coverage Δ
linux 83.25% <ø> (-0.16%) ⬇️
macos 83.25% <ø> (-0.16%) ⬇️
windows 83.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Retry/RetryResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
...eout/TimeoutResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
.../RateLimiterResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)

@martintmk martintmk merged commit aee8e5e into main Jun 13, 2023
@martintmk martintmk deleted the mtomka/drop-some-extensions branch June 13, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants